Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ocis commit id #6503

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Bump ocis commit id #6503

merged 2 commits into from
Mar 2, 2022

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Mar 1, 2022

@fschade fschade requested a review from kulmann March 1, 2022 14:21
@fschade fschade self-assigned this Mar 1, 2022
@update-docs
Copy link

update-docs bot commented Mar 1, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade fschade mentioned this pull request Mar 1, 2022
Closed
31 tasks
pascalwengerter
pascalwengerter reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't bump a commit ID? Also would recommend to run as [full-ci] to see all failures!

@fschade
Copy link
Contributor Author

fschade commented Mar 1, 2022

@pascalwengerter as soon as we have the commit id i bump it.
Its still a pending ocis PR!

@ownclouders
Copy link
Contributor

Results for oCISFiles4 https://drone.owncloud.com/owncloud/web/23148/58/1
The following scenarios passed on retry:

  • webUIRenameFolders/renameFolders.feature:142

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23148/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L78.png

webUISharingPublicManagement-shareByPublicLink_feature-L78.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@saw-jan saw-jan mentioned this pull request Mar 2, 2022
Closed
13 tasks
@fschade fschade marked this pull request as ready for review March 2, 2022 16:52
@fschade fschade force-pushed the bump-ocis-commit-id branch from c66e5e4 to 7954841 Compare March 2, 2022 16:53
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23199/68/1
The following scenarios passed on retry:

  • webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:199

@fschade fschade merged commit 1318eaa into master Mar 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-ocis-commit-id branch March 2, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@fschade fschade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating public link share still has # in the link with the latest oCIS server and the link doesn't work.
3 participants
@fschade @ownclouders @pascalwengerter